Skip to content

fix to current class model#4

Open
RhinoLu wants to merge 2 commits intoCreateJS:masterfrom
RhinoLu:RhinoLu-fix
Open

fix to current class model#4
RhinoLu wants to merge 2 commits intoCreateJS:masterfrom
RhinoLu:RhinoLu-fix

Conversation

@RhinoLu
Copy link

@RhinoLu RhinoLu commented Sep 10, 2015

No description provided.

@lannymcnie
Copy link
Member

This port is not quite complete.

  1. The initialize method has been deprecated in favor of using the constructor
  2. Properties should no longer be declared on the prototype, but rather initialized and document inside of the constructor.
  3. The new extend/promote removes the need for the p.DisplayObject_function = p.function approach, so those should be removed.

I also recommend changing the .addEventListener usages in the demo to .on().

If you can address these changes, I will accept the PR. Thanks for updating this class, and sorry for the late response!

Please check again. If there still have any mistake, just tell me.
Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants